Implemented: logic to update notification icon after viewing and added notification preference card on the settings page (#301) #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d preference card on the settings page (#301)
ymaheshwari1
requested changes
Oct 3, 2023
ymaheshwari1
requested changes
Oct 5, 2023
ravilodhi
reviewed
Oct 6, 2023
ymaheshwari1
requested changes
Oct 6, 2023
ymaheshwari1
approved these changes
Oct 9, 2023
dt2patel
reviewed
Oct 12, 2023
| }, | ||
| async updateNotificationPref(enumId: string, event: any) { | ||
| try { | ||
| const ofbizInstanceName = this.userProfile.ofbizInstanceName |
There was a problem hiding this comment.
This should be "omsInstanceName" we can't make this specific to Ofbiz @ravilodhi
There was a problem hiding this comment.
Yes, got it. Will make changes to the Get Use Profile API and the respective occurrences on the UI side. Currently, this variable does not hold an OMS instance name, it is going to be a unique keyword. Currently "hotwax" is getting set for all the instances during deployment and used internally for some operations.
I had a discussion with Deepak Sir to set this to some unique value (most probably the OMS instance) so that the firebase topic can be created uniquely per OMS instance.
@dt2patel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #301
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
Contribution and Currently Important Rules Acceptance